Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor factorising #188

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

minor factorising #188

wants to merge 29 commits into from

Conversation

nitronit
Copy link
Contributor

@nitronit nitronit commented Aug 7, 2023 •
edited
Loading

A start to factorising the signer directory.

Will be easier in the future to "take" out the cosigner/signers etc into a separate packages and we can get ride of the signer directory.

Also added some misc documentation for references and futures use.

  • Clarify documentation, including right references.
  • Refactor cosigner and thresholdValidator into two distinct "packages"
  • Make thresholdValidator take interfaces (abstract out cosigner)

agouin
agouin reviewed Sep 2, 2023
View reviewed changes
Copy link
Member

@agouin agouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a large PR, so I may have missed some things, but I gave a review for my first pass through. Overall, the refactor looks great by breaking up the signer pkg into smaller packages.

test/validator_single.go Outdated Show resolved Hide resolved
cmd/horcrux/cmd/address.go Outdated
@@ -6,11 +6,12 @@ import (
"fmt"
"strings"

"github.com/strangelove-ventures/horcrux/pkg/pcosigner"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's just call this cosigner instead of pcosigner

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!
Will fix it.

cmd/horcrux/cmd/threshold.go Outdated Show resolved Hide resolved
docs/metrics.md Show resolved Hide resolved
docs/migrating.md Show resolved Hide resolved
pkg/node/grpc_server.go Outdated Show resolved Hide resolved
pkg/node/raft_store.go Outdated Show resolved Hide resolved
pkg/node/raft_store_test.go Outdated Show resolved Hide resolved
pkg/node/raft_store_test.go Show resolved Hide resolved
pkg/node/single_signer_validator_test.go Outdated Show resolved Hide resolved
@nitronit nitronit marked this pull request as ready for review September 5, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agouin agouin agouin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitronit @agouin